Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/simplify is known function #126

Merged
merged 4 commits into from
May 17, 2024

Conversation

juanjoDiaz
Copy link
Collaborator

Partially solves #125

We still need to redo the dictionaries, etc.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (6049223) to head (a0bef86).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   96.36%   96.34%   -0.02%     
==========================================
  Files          32       32              
  Lines         578      575       -3     
==========================================
- Hits          557      554       -3     
  Misses         21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adbar
Copy link
Owner

adbar commented May 16, 2024

The PR moves is_known() out of the Lemmatizer class and removes the greedy argument, all good!

@juanjoDiaz juanjoDiaz force-pushed the feat/simplify_is_known_function branch from 5e092fe to a0bef86 Compare May 16, 2024 18:46
@adbar adbar merged commit 39ff74d into adbar:main May 17, 2024
16 checks passed
@adbar
Copy link
Owner

adbar commented May 17, 2024

Great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants